chore: improve marketplace integration tests #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2-towns
force-pushed
the
chore/improve-marketplace-integration-tests
branch
2 times, most recently
from
7afc7bc to
a8af3b4
Compare
2-towns
force-pushed
the
chore/improve-marketplace-integration-tests
branch
from
a8af3b4 to
b1d2304
Compare
markspanbroek
approved these changes
Jun 16, 2025
tests/integration/testproofs.nim
Outdated
Comment on lines
79
to
82
| marketplacesuite( | ||
| name = "Simulate invalid proofs", | ||
| stopOnRequestFail = false, | ||
| body = block: |
There was a problem hiding this comment.
I think you can also write this as:
marketplacesuite("Simulate invalid proofs", stopOnRequestFail=false):
Then you don't need to change the indentation below.
There was a problem hiding this comment.
Yes, I already tried but got this error:
Expected one of (first mismatch at [position]):
[3] template marketplacesuite(name: string; body: untyped; stopOnRequestFail = true)
positional param was already given as named param
There was a problem hiding this comment.
Yes, the body would need to be the last parameter of marketplacesuite for it to work with the : syntax.
tests/integration/testvalidator.nim
Outdated
Comment on lines
18
to
21
| marketplacesuite( | ||
| name = "Validation", | ||
| stopOnRequestFail = false, | ||
| body = block: |
There was a problem hiding this comment.
Same here:
marketplacesuite("Validation", stopOnRequestFail = false):
2-towns
force-pushed
the
chore/improve-marketplace-integration-tests
branch
from
80c0e87 to
2dd760e
Compare
benbierens
approved these changes
Jun 18, 2025
…se the poll interval to reduce the number of requests.
markspanbroek
force-pushed
the
chore/improve-marketplace-integration-tests
branch
from
2dd760e to
e6da066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of
check eventuallywith an event subscription mechanism in order to reduce the number of requests sent in our tests and avoid connection timeouts due to overload.Additionally, it introduces
stopOnRequestFail(set to true by default) formarketplacesuite, which will fail the test if a request fails.Finally, it bumps the contracts to use the latest version of Hardhat.